Skip to content

Qualcomm AI Engine Direct - Fixed the wrong size for memmove in kv_manager #14685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cccclai merged 1 commit into from
Sep 30, 2025
Merged

Qualcomm AI Engine Direct - Fixed the wrong size for memmove in kv_manager #14685

cccclai merged 1 commit into from
Sep 30, 2025

Conversation

@shewu-quic
Copy link
Collaborator

@shewu-quic shewu-quic commented Sep 30, 2025 •
edited
Loading

As title.

cc: @haowhsu-quic , @winskuo-quic

@shewu-quic shewu-quic requested a review from cccclai as a code owner September 30, 2025 07:17
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14685

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 9ea1583 with merge base ebf4c12 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2025
@shewu-quic
Copy link
Collaborator Author

shewu-quic commented Sep 30, 2025

@pytorchbot cherry-pick --onto release/1.0 -c regression

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@shewu-quic shewu-quic changed the title Qualcomm AI Engine Direct - Fixed the bug for memmove in kv_manager Qualcomm AI Engine Direct - Fixed the wrong size for memmove in kv_manager Sep 30, 2025
@cccclai
Copy link
Contributor

cccclai commented Sep 30, 2025

Can you share more details in terms of what we're fixing?

cccclai
cccclai reviewed Sep 30, 2025
View reviewed changes
examples/qualcomm/oss_scripts/llama/runner/kv_manager.cpp
// copy from first dimension
for (int i = 0; i < metadata_.head_dim; i++) {
std::memmove(k_cache_in_write_ptr, k_cache_in_read_ptr, dst_cache_num);
std::memmove(
Copy link
Contributor

@cccclai cccclai Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see, makes sense

@cccclai cccclai merged commit f662cf5 into pytorch:main Sep 30, 2025
128 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shewu-quic @cccclai